mengw15 commented on code in PR #8626:
URL: https://github.com/apache/texera/pull/8626#discussion_r4066216286
##########
.github/workflows/direct-backport-push.yml:
##########
@@ -1016,9 +1070,12 @@ jobs:
pr = (await github.rest.pulls.create({
owner, repo, base: TARGET_BRANCH, head: BRANCH,
- title, body, draft: true,
+ // A clean backport opens ready for review: nobody has code to
+ // write on it, and a draft would only suggest otherwise. It
+ // still needs its checks started -- the comment below says
how.
+ title, body, draft: !clean,
Review Comment:
Fixed in b70d4f3d4, by failing closed rather than rewriting the PR: when the
re-run's outcome no longer matches the open PR's draft state, it says so on
that PR, reds `backport/<branch>` and fails the job. Rewriting the PR from the
workflow would overwrite whatever a human has done to it since it was opened.
##########
.github/workflows/direct-backport-push.yml:
##########
@@ -1044,7 +1101,10 @@ jobs:
} catch (e) {
core.warning(`Could not fetch PR #${prNumber} author:
${e.message}`);
}
- if (author) {
+ // Only a backport somebody has to finish gets assigned. A clean
+ // one is the release manager's to review, and assigning its author
+ // would tell them they have work they do not have.
+ if (author && !clean) {
Review Comment:
Fixed in b70d4f3d4: `if (MANAGER && (clean || MANAGER !== author))`. That
guard only ever made sense for a conflicted backport's assignee — a clean one
has none, and the PR is owned by `github-actions[bot]`, so the source author is
not its author.
##########
.github/workflows/direct-backport-push.yml:
##########
@@ -314,11 +314,23 @@ jobs:
`PR #${pullRequest.number}: push=[${push.join(", ")}]
pr=[${pr.join(", ")}]`
);
+ // Both outcomes open a pull request. Pushing a cherry-pick
+ // straight onto a release branch is rejected by the Merge Queue
+ // ruleset that covers them (#8377), and ASF policy asks for
prior
+ // Infrastructure authorization before an automated service
writes
+ // a branch subject to official release -- so a backport travels
+ // the way every other change to a release branch travels.
Review Comment:
Fixed in b70d4f3d4, all three: the entries comment here,
`release-branches.yml`, and `create-backport-branch.sh`'s header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
