Copilot commented on code in PR #8626:
URL: https://github.com/apache/texera/pull/8626#discussion_r4066280879
##########
.github/workflows/direct-backport-push.yml:
##########
@@ -1071,23 +1179,35 @@ jobs:
try {
await github.rest.issues.createComment({
owner, repo, issue_number: prNumber,
- body:
- `Backport PR opened: draft #${pr.number} (${prUrl}) to ` +
- `\`${TARGET_BRANCH}\`` +
- (author ? `, assigned to @${author}` : "") +
- ` — needs manual work because ${reason}.`,
+ body: clean
+ ? `Backport PR opened: #${pr.number} (${prUrl}) to ` +
+ `\`${TARGET_BRANCH}\` — the cherry-pick was clean, so it
is ` +
+ `ready for review` +
+ (MANAGER ? `, waiting on @${MANAGER}` : "") +
+ `. It needs to be reopened once to start its checks; the
PR ` +
+ `says how.`
+ : `Backport PR opened: draft #${pr.number} (${prUrl}) to ` +
+ `\`${TARGET_BRANCH}\`` +
+ (author ? `, assigned to @${author}` : "") +
+ ` — needs manual work because ${reason}.`,
});
} catch (e) {
core.warning(`Could not comment on #${prNumber}: ${e.message}`);
}
// A failure commit status on the merge commit keeps the "needs
// backport" signal visible on main next to the successful ones.
+ // A clean backport carries it too: it is open, not landed, and
+ // something still has to be done to it. The status turning green
+ // is not what this workflow reports -- the merge into the release
+ // branch is.
try {
await github.rest.repos.createCommitStatus({
owner, repo, sha: MERGE_SHA, state: "failure",
context: `backport/${TARGET_BRANCH}`,
- description: `Draft backport PR #${pr.number} opened`,
+ description: clean
+ ? `Backport PR #${pr.number} open, awaiting review`
+ : `Draft backport PR #${pr.number} opened`,
Review Comment:
This status is never updated after the backport PR merges. Repository-wide,
the only success writes for this context are in the now-unreachable
`push-backports` job and the feature-absent path, so every clean backport will
leave its source commit permanently red with the stale description “open,
awaiting review” even after it lands. Add a merge/close handler that updates
`backport/${TARGET_BRANCH}` (and handles closed-unmerged PRs) so this status
reflects the eventual outcome.
##########
.github/workflows/direct-backport-push.yml:
##########
@@ -314,11 +316,23 @@ jobs:
`PR #${pullRequest.number}: push=[${push.join(", ")}]
pr=[${pr.join(", ")}]`
);
+ // Both outcomes open a pull request. Pushing a cherry-pick
+ // straight onto a release branch is rejected by the Merge Queue
+ // ruleset that covers them (#8377), and ASF policy asks for
prior
+ // Infrastructure authorization before an automated service
writes
+ // a branch subject to official release -- so a backport travels
+ // the way every other change to a release branch travels.
Review Comment:
This routing change leaves the preflight's user-visible result inaccurate:
`.github/workflows/backport-publish.yml:96-97` still tells users that a clean
result will be cherry-picked straight to the release branch, and
`.github/workflows/backport-checks.yml:30-31` documents the same old split.
Please update those remaining references so the source PR describes the new
always-open-a-PR behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
