mengw15 commented on code in PR #8626:
URL: https://github.com/apache/texera/pull/8626#discussion_r4066492436
##########
.github/workflows/direct-backport-push.yml:
##########
@@ -1071,23 +1179,35 @@ jobs:
try {
await github.rest.issues.createComment({
owner, repo, issue_number: prNumber,
- body:
- `Backport PR opened: draft #${pr.number} (${prUrl}) to ` +
- `\`${TARGET_BRANCH}\`` +
- (author ? `, assigned to @${author}` : "") +
- ` — needs manual work because ${reason}.`,
+ body: clean
+ ? `Backport PR opened: #${pr.number} (${prUrl}) to ` +
+ `\`${TARGET_BRANCH}\` — the cherry-pick was clean, so it
is ` +
+ `ready for review` +
+ (MANAGER ? `, waiting on @${MANAGER}` : "") +
+ `. It needs to be reopened once to start its checks; the
PR ` +
+ `says how.`
+ : `Backport PR opened: draft #${pr.number} (${prUrl}) to ` +
+ `\`${TARGET_BRANCH}\`` +
+ (author ? `, assigned to @${author}` : "") +
+ ` — needs manual work because ${reason}.`,
});
} catch (e) {
core.warning(`Could not comment on #${prNumber}: ${e.message}`);
}
// A failure commit status on the merge commit keeps the "needs
// backport" signal visible on main next to the successful ones.
+ // A clean backport carries it too: it is open, not landed, and
+ // something still has to be done to it. The status turning green
+ // is not what this workflow reports -- the merge into the release
+ // branch is.
try {
await github.rest.repos.createCommitStatus({
owner, repo, sha: MERGE_SHA, state: "failure",
context: `backport/${TARGET_BRANCH}`,
- description: `Draft backport PR #${pr.number} opened`,
+ description: clean
+ ? `Backport PR #${pr.number} open, awaiting review`
+ : `Draft backport PR #${pr.number} opened`,
Review Comment:
Not introduced here and deliberately not fixed here: nothing has ever
updated this status after it is written, so a landed backport already stays red
— #8562's `backport/release/v1.2` still names the draft #8585, which merged on
2026-09-19. Routing the clean ones through a PR widens it from some commits to
all of them, and the comment now says so. Settling it needs a handler on the
backport PR closing; that belongs with the removal of `push-backports`, which
holds the only success write for this context. Tracked in #8632.
##########
.github/workflows/direct-backport-push.yml:
##########
@@ -314,11 +316,23 @@ jobs:
`PR #${pullRequest.number}: push=[${push.join(", ")}]
pr=[${pr.join(", ")}]`
);
+ // Both outcomes open a pull request. Pushing a cherry-pick
+ // straight onto a release branch is rejected by the Merge Queue
+ // ruleset that covers them (#8377), and ASF policy asks for
prior
+ // Infrastructure authorization before an automated service
writes
+ // a branch subject to official release -- so a backport travels
+ // the way every other change to a release branch travels.
Review Comment:
Fixed in a71cc51ec — `backport-publish.yml`'s clean summary (the one a
contributor reads) and `backport-checks.yml`'s header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
