yangzhang75 commented on code in PR #8581:
URL: https://github.com/apache/texera/pull/8581#discussion_r4066476817
##########
frontend/src/app/workspace/service/execute-workflow/execute-workflow.service.ts:
##########
@@ -383,6 +444,8 @@ export class ExecuteWorkflowService {
this.currentState = {
state: ExecutionState.Uninitialized,
};
+ // Otherwise the next workflow's menu opens showing the previous run's
time.
+ this.anchorDuration(0, false);
Review Comment:
Fixed, and the correction is on me: I said in the neighbouring thread that
this path went through `resetExecutionState`. It does not --
`resetExecutionAndWorkers` calls `updateExecutionState` directly -- and I had
not checked before saying so.
It re-anchors the clock at zero now, which also stops the ticker, so leaving
a workflow mid-run no longer carries a counting clock into the next one. Test:
a running clock taken through this path reads zero, and still reads zero twenty
seconds later; deletion-checked. b3d9def
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
