mengw15 commented on code in PR #8581:
URL: https://github.com/apache/texera/pull/8581#discussion_r4075671408
##########
frontend/src/app/workspace/component/workflow-editor/mini-map/mini-map.component.ts:
##########
@@ -17,13 +17,16 @@
* under the License.
*/
-import { AfterViewInit, Component, HostListener, OnDestroy, ViewChild } from
"@angular/core";
+import { AfterViewInit, Component, ElementRef, HostListener, OnDestroy,
ViewChild } from "@angular/core";
import { UntilDestroy, untilDestroyed } from "@ngneat/until-destroy";
import { WorkflowActionService } from
"../../../service/workflow-graph/model/workflow-action.service";
import { MAIN_CANVAS } from "../workflow-editor.component";
import * as joint from "jointjs";
import { JointGraphWrapper } from
"../../../service/workflow-graph/model/joint-graph-wrapper";
import { PanelService } from "../../../service/panel/panel.service";
+
+/** The main paper's events that move or resize its viewport, which is what
the navigator tracks. */
+const MAIN_PAPER_EVENTS = ["translate", "scale", "resize"] as const;
import { CdkDrag } from "@angular/cdk/drag-drop";
Review Comment:
ES modules allow top-level statements between `import` declarations —
imports are hoisted, and the specification does not require them to come first.
TypeScript compiles this as written, and the frontend build on this head is
green on macOS and Windows (`build:ci` runs the AOT production build, eslint
and prettier before the unit tests), so the file is valid as it stands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
