mengw15 commented on PR #8648: URL: https://github.com/apache/texera/pull/8648#issuecomment-5790290884
Dropping the backport labels. The change itself looks right for `main` — `toLowerCase` is the correct choice for a machine identifier. It is not reachable with the operator types that exist, though: Turkish folding only affects an uppercase `I`, and the only `operatorType` values containing "sink" are `SimpleSink` and `Sink`, neither of which has one. No input distinguishes the two implementations, so nothing on a release branch behaves differently with or without this. For the record, the locale-dependent form came in on 2022-02-11 with #1408, which extracted `isSink` from a call site that had been using `toLowerCase`. (The `feature` label also looks unintended for a `fix(...)` title.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
