Ma77Ball commented on code in PR #8648:
URL: https://github.com/apache/texera/pull/8648#discussion_r4086151261


##########
frontend/src/app/workspace/service/workflow-graph/model/workflow-graph.spec.ts:
##########
@@ -27,9 +27,15 @@ import {
   mockSentimentPredicate,
   mockSentimentResultLink,
 } from "./mock-workflow-data";
-import { WorkflowGraph } from "./workflow-graph";
+import { WorkflowGraph, isSink } from "./workflow-graph";
+import {
+  Comment,
+  OperatorLink,
+  OperatorPredicate,
+  PortDescription,
+  PortProperty,
+} from "../../../types/workflow-common.interface";
 import { Observable } from "rxjs";

Review Comment:
   The rxjs `Observable` import was moved below the `workflow-common` import, 
which adds diff noise unrelated to the fix. Please move it back to its original 
place. 
   
   Suggested fix:
   
   ```suggestion
   import { WorkflowGraph, isSink } from "./workflow-graph";
   import { Observable } from "rxjs";
   import {
     Comment,
     OperatorLink,
     OperatorPredicate,
     PortDescription,
     PortProperty,
   } from "../../../types/workflow-common.interface";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to