CaroFernando opened a new pull request, #8648:
URL: https://github.com/apache/texera/pull/8648
### What changes were proposed in this PR?
`isSink` folded operator types with `toLocaleLowerCase()`, which is
locale-dependent. In a Turkish-locale browser an uppercase `I` folds to `ı`,
so a type spelled `SINK` becomes `sınk` and stops matching: the operator
drops out of the result panel and becomes eligible for the result-view and
cache toggles it is meant to be excluded from. An operator type is a machine
identifier, so case folding must not depend on the browser's locale.
Before: `isSink("SINK")` can return false under a Turkish runtime locale
After: `isSink("SINK")` is always true
Adds direct unit coverage for `isSink`: the casing contract, negative
cases, and a regression test that stubs `toLocaleLowerCase` with Turkish
folding — the one case `#8603` cannot pin, since it fails on the old
implementation.
### Any related issues, documentation, discussions?
Closes #8616
Sequenced on #8603 (test-only coverage for the same helpers, same spec file).
Whichever of the two merges first should rebase the other.
### How was this PR tested?
- Targeted spec: `yarn ng test --watch=false --include
"src/app/workspace/service/workflow-graph/model/workflow-graph.spec.ts"` — 72
passed (regression test proved red before the fix)
- Full frontend suite: `yarn test:ci` — 229 files, 6244 passed, 1 skipped
(pre-existing)
- `eslint` and `prettier --check` clean on changed files
### Was this PR authored or co-authored using generative AI tooling?
Yes. Co-authored with Claude Code; reviewed before submission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
