eugenegujing commented on code in PR #7944:
URL: https://github.com/apache/texera/pull/7944#discussion_r4099854569
##########
frontend/src/app/common/type/workflow-computing-unit.ts:
##########
@@ -46,7 +46,10 @@ export interface WorkflowComputingUnitMetrics {
export interface DashboardWorkflowComputingUnit {
computingUnit: WorkflowComputingUnit;
- status: "Running" | "Pending";
+ status: "Running" | "Pending" | "Failed" | "Unknown" | "Terminating";
+ // User-friendly explanation of a failing/degraded status for authorized
viewers. The backend
+ // omits it for ordinary shared users, so the UI falls back to generic
"unavailable" text.
+ statusReason?: string;
Review Comment:
Fixed in 830f26117.
##########
frontend/src/app/workspace/component/power-button/computing-unit-selection.component.html:
##########
@@ -198,7 +198,7 @@
'unit-selected': isSelectedUnit(unit),
'unit-connecting': unit.status === 'Pending',
}"
- [nz-tooltip]="cannotSelectUnit(unit) ? getUnitStatusTooltip(unit) + '.
Cannot select.' : ''"
+ [nz-tooltip]="getRowTooltip(unit)"
Review Comment:
Fixed in 830f26117.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]