kunwp1 commented on code in PR #7944:
URL: https://github.com/apache/texera/pull/7944#discussion_r4101066078
##########
frontend/src/app/workspace/component/power-button/computing-unit-selection.component.html:
##########
@@ -209,19 +209,9 @@
[style.opacity]="0.7">
</texera-user-avatar>
<div class="computing-unit-name">
- <nz-badge
- [nzColor]="getBadgeColor(unit.status)"
- [nz-tooltip]="getUnitStatusTooltip(unit)"></nz-badge>
- <span
- *ngIf="editingNameOfUnit !== unit.computingUnit.cuid; else
editableUnitName"
- nz-tooltip
- [nzTooltipTitle]="unit.computingUnit.uri">
Review Comment:
Did you intend to remove the tooltip on the unit name?
##########
frontend/src/app/workspace/component/workflow-form/workflow-form.component.ts:
##########
@@ -1563,15 +1572,25 @@ export class WorkflowFormComponent implements OnInit,
OnDestroy {
if (this.isConnecting) {
return { label: "Connecting", icon: "loading", disabled: true };
}
+ // The socket may already be gone here, for a terminal unit or one that
vanished mid-run.
+ // A kill on a dead socket is lost, so Stop is only enabled while it can
be delivered.
if (this.isRunning) {
- return { label: "Stop", icon: "stop", disabled: false };
+ return { label: "Stop", icon: "stop", disabled:
!this.workflowWebsocketService.isConnected };
}
Review Comment:
I think here if the unit dies mid-run, this shows a disabled Stop forever
and the button never reaches Unavailable state. I suggest to move the
`isConnected` condition in the if statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
