eugenegujing commented on code in PR #7944:
URL: https://github.com/apache/texera/pull/7944#discussion_r4109561004
##########
frontend/src/app/workspace/component/workflow-form/workflow-form.component.ts:
##########
@@ -1563,15 +1572,25 @@ export class WorkflowFormComponent implements OnInit,
OnDestroy {
if (this.isConnecting) {
return { label: "Connecting", icon: "loading", disabled: true };
}
+ // The socket may already be gone here, for a terminal unit or one that
vanished mid-run.
+ // A kill on a dead socket is lost, so Stop is only enabled while it can
be delivered.
if (this.isRunning) {
- return { label: "Stop", icon: "stop", disabled: false };
+ return { label: "Stop", icon: "stop", disabled:
!this.workflowWebsocketService.isConnected };
}
Review Comment:
fixed in 1850e9614ac530c41209258d368f324e418a6a1a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
