ulidtko commented on pull request #2197: URL: https://github.com/apache/thrift/pull/2197#issuecomment-672225995
Hi @zeshuai007 — well, that totally makes sense. I retested with Java 8 (OpenJDK as before). The result with Java8 (for `test.py --server java --client erl` only) is **success of all tests** for me. Both with TLS1.3 allowed and disallowed for the Erlang client — the java server doesn't offer TLS1.3, exactly as you say; so it just negotiates down to TLS1.2, and all proceeds well from there. Which is a puzzling result. I remember seeing this failure on Travis — but can no longer find any build exhibiting it. Do you perhaps have a link to such a build on Travis? I did found [one](https://travis-ci.org/github/apache/thrift/jobs/665484688) from March 22, which has reached running the `cross` step — and had passed all of it (log line 21337 onwards). Notice (log line 13268) that it used Java 11! That confused me at first, since Java11 + Erlang23 = TLS1.3 = broken according to my testing, should not have passed — but as you mention, Erlang/OTP 23 was only released in May, later than the build I linked. What makes you think that Java 8 is in use? Can you find a failed build with Java 8 on Travis? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
