dcelasun commented on a change in pull request #2497:
URL: https://github.com/apache/thrift/pull/2497#discussion_r779804626
##########
File path: lib/go/thrift/simple_server.go
##########
@@ -193,7 +195,13 @@ func (p *TSimpleServer) innerAccept() (int32, error) {
}
if client != nil {
p.wg.Add(1)
+ p.clients[client] = struct{}{}
go func() {
+ defer func() {
+ p.mu.Lock()
+ defer p.mu.Unlock()
+ delete(p.clients, client)
Review comment:
Breaking `TTransport` will definitely be painful. When we added
`context.Context` to function signatures, it broke so many downstream projects.
This won't be as bad, but still.
Anyway, as long as we're adding new API to `TTransport` I like `Addr()
net.Addr` better than `Unwrap() TTransport`. It feels more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
