dcelasun commented on a change in pull request #2497:
URL: https://github.com/apache/thrift/pull/2497#discussion_r779806976
##########
File path: lib/go/thrift/simple_server.go
##########
@@ -193,7 +195,13 @@ func (p *TSimpleServer) innerAccept() (int32, error) {
}
if client != nil {
p.wg.Add(1)
+ p.clients[client] = struct{}{}
go func() {
+ defer func() {
+ p.mu.Lock()
+ defer p.mu.Unlock()
+ delete(p.clients, client)
Review comment:
I'm also not a fan of the opt-in or documentation approaches. The
former, because the current behaviour is wrong and should be fixed, and the
latter because I don't think end users should worry about an OOM caused by an
internal implementation detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
