dcelasun commented on a change in pull request #2497:
URL: https://github.com/apache/thrift/pull/2497#discussion_r779900017
##########
File path: lib/go/thrift/simple_server.go
##########
@@ -193,7 +195,13 @@ func (p *TSimpleServer) innerAccept() (int32, error) {
}
if client != nil {
p.wg.Add(1)
+ p.clients[client] = struct{}{}
go func() {
+ defer func() {
+ p.mu.Lock()
+ defer p.mu.Unlock()
+ delete(p.clients, client)
Review comment:
> we trade a (kinda unbounded) map with one additional goroutine per
client connection. the big advantage is that we no longer need to make a
breaking change to TTransport to make it usable in a map.
Sounds much more reasonable. @buptubuntu what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
