emmenlau commented on code in PR #2649: URL: https://github.com/apache/thrift/pull/2649#discussion_r967640902
########## lib/cpp/src/thrift/transport/TServerSocket.cpp: ########## @@ -70,7 +70,7 @@ // adds problematic macros like min() and max(). Try to work around: #define NOMINMAX #define WIN32_LEAN_AND_MEAN -#include <Windows.h> +#include <windows.h> Review Comment: @evetion I'm sorry but I'm not sure that this is actually portable. I've googled a bit and found https://stackoverflow.com/a/15466951/7200132 where the stance is: > newer VC++ installations and Windows SDKs seem to use `Windows.h` I've checked on my development machine with Visual Studio 2022 17.3.3, and found the header to be: ``` /c/Program Files (x86)/Windows Kits/10/Include/10.0.20348.0/um/Windows.h ``` So is it possible that your specific development environment is "special"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
