emmenlau commented on code in PR #2649:
URL: https://github.com/apache/thrift/pull/2649#discussion_r967835015
##########
lib/cpp/src/thrift/transport/TServerSocket.cpp:
##########
@@ -70,7 +70,7 @@
// adds problematic macros like min() and max(). Try to work around:
#define NOMINMAX
#define WIN32_LEAN_AND_MEAN
-#include <Windows.h>
+#include <windows.h>
Review Comment:
I'm not sure I fully understand this conclusion, please help.
Here is my thinking:
- Based on Stackoverflow, we assume that `newer VC++ installations and
Windows SDKs seem to use Windows.h` (with uppercase first letter), correct?
- If I where to copy or extract such an installation onto a case-sensitive
file system, then I would need to use `Windows.h` as the correct casing,
correct?
Why would `windows.h` (with lowercase spelling) be a better, or even a good,
alternative, if the default casing is `Windows.h`? That seems to jump out of
context, or I'm missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
