emmenlau commented on code in PR #2649: URL: https://github.com/apache/thrift/pull/2649#discussion_r967835164
########## lib/cpp/src/thrift/transport/TServerSocket.cpp: ########## @@ -70,7 +70,7 @@ // adds problematic macros like min() and max(). Try to work around: #define NOMINMAX #define WIN32_LEAN_AND_MEAN -#include <Windows.h> +#include <windows.h> Review Comment: And also, if `Windows.h` is the default casing, why does *your* case-sensitive installation use `windows.h` instead? Isn't this the "odd" case, and `Windows.h` is the common case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
