fishy commented on PR #2888: URL: https://github.com/apache/thrift/pull/2888#issuecomment-1828249596
Thanks. Please 1. Add a test to verify the fix 2. Claim the [jira ticket](https://issues.apache.org/jira/browse/THRIFT-3037) (cc @dcelasun you claimed the ticket previously) 3. instead of `type TypedefExampleRequest struct { *ExampleRequest }`, why not just `type TypedefExampleRequest = ExampleRequest`? that will make things much simpler isn't it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
