fishy commented on code in PR #2888:
URL: https://github.com/apache/thrift/pull/2888#discussion_r1408550253
##########
lib/go/test/Makefile.am:
##########
@@ -172,4 +175,5 @@ EXTRA_DIST = \
TypedefFieldTest.thrift \
UnionBinaryTest.thrift \
UnionDefaultValueTest.thrift \
- ValidateTest.thrift
+ ValidateTest.thrift \
+ TypedefServiceTest.thrift
Review Comment:
wrong indentation (should be a tab instead of 4 spaces)
##########
lib/go/test/Makefile.am:
##########
@@ -62,7 +62,8 @@ gopath: $(THRIFT) $(THRIFTTEST) \
ProcessorMiddlewareTest.thrift \
ClientMiddlewareExceptionTest.thrift \
ValidateTest.thrift \
- ForwardType.thrift
+ ForwardType.thrift \
+ TypedefServiceTest.thrift
Review Comment:
same here
##########
compiler/cpp/src/thrift/generate/t_go_generator.h:
##########
@@ -176,7 +177,8 @@ class t_go_generator : public t_generator {
t_struct* tstruct,
bool is_pointer_field,
bool declare,
- std::string prefix = "");
+ std::string prefix = "",
+ string alias_name = "");
Review Comment:
can you use `std::string` over `string` here?
it doesn't look like we are very consistent here, but being consistent
partially is still better, while the line right above is using `std::string`
it's better to keep that.
##########
compiler/cpp/src/thrift/generate/t_go_generator.h:
##########
@@ -124,7 +124,8 @@ class t_go_generator : public t_generator {
bool is_args = false);
void generate_go_struct_initializer(std::ostream& out,
t_struct* tstruct,
- bool is_args_or_result = false);
+ bool is_args_or_result = false,
+ string alias_name = "");
Review Comment:
similar here, let's use `std::string` instead
##########
lib/go/test/Makefile.am:
##########
@@ -124,7 +126,8 @@ check: gopath
./gopath/src/processormiddlewaretest \
./gopath/src/clientmiddlewareexceptiontest \
./gopath/src/validatetest \
- ./gopath/src/forwardtypetest
+ ./gopath/src/forwardtypetest \
+ ./gopath/src/typedefservicetest
Review Comment:
wrong indentation (should be 4 spaces)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
