fishy commented on PR #2888: URL: https://github.com/apache/thrift/pull/2888#issuecomment-1828788249
also, thrift files under `test/` are for all languages and are not necessarily run by all language tests (currently there's no go test specifically run against `test/TypedefTest.thrift`, it's just the compiler change you made complete broke the go code so it failed the test). for go specific tests I'd suggest you to put it under `lib/go/test` instead. Note that currently tests under `lib/go/test` is not run by CI, see https://github.com/apache/thrift/pull/2886 (after that is merged the CI will run those tests) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
