emmenlau commented on code in PR #2943:
URL: https://github.com/apache/thrift/pull/2943#discussion_r1524338956
##########
compiler/cpp/src/thrift/generate/t_cl_generator.cc:
##########
@@ -221,11 +221,11 @@ void t_cl_generator::package_def(std::ostream &out) {
}
out << ")";
}
- out << ")" << endl << endl;
+ out << ")\n\n";
Review Comment:
I'm slightly with @fishy here, as my comment in
https://github.com/apache/thrift/pull/2943#issuecomment-1986363604 was actually
going in the same direction: Having dedicated calls to `<< "\n"` jumps much
more to the eye and conveyes how many newlines are added.
If you would be willing to change that, to make every newline jump out more,
I'm two thumbs up for this PR! But without that change, I'm still ok to merge,
albeit with minor hesitation...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
