CJCombrink commented on code in PR #2943: URL: https://github.com/apache/thrift/pull/2943#discussion_r1524674743
########## compiler/cpp/src/thrift/generate/t_cl_generator.cc: ########## @@ -221,11 +221,11 @@ void t_cl_generator::package_def(std::ostream &out) { } out << ")"; } - out << ")" << endl << endl; + out << ")\n\n"; Review Comment: @emmenlau Thank you again for the feedback. I think there is enough reason to put back the `<< "\n` thus I will put in the effort (tonight) to 'revert' that change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org