thomasbruggink commented on PR #2937:
URL: https://github.com/apache/thrift/pull/2937#issuecomment-2002225856
> ```
> make distdir-am
> make[6]: Entering directory '/thrift/src/lib/cpp'
> (cd test && make top_distdir=../../../thrift-0.21.0
distdir=../../../thrift-0.21.0/lib/cpp/test \
> am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=:
distdir)
> make[7]: Entering directory '/thrift/src/lib/cpp/test'
> /thrift/src/compiler/cpp/thrift --gen cpp
../../../test/AnnotationTest.thrift
> /bin/bash: line 1: /thrift/src/compiler/cpp/thrift: No such file or
directory
> make[7]: *** [Makefile:1880: gen-cpp/AnnotationTest_types.h] Error 127
> make[7]: Leaving directory '/thrift/src/lib/cpp/test'
> make[6]: *** [Makefile:1685: distdir-am] Error 1
> make[6]: Leaving directory '/thrift/src/lib/cpp'
> make[5]: *** [Makefile:1681: distdir] Error 2
> make[5]: Leaving directory '/thrift/src/lib/cpp'
> make[4]: *** [Makefile:672: distdir-am] Error 1
> make[4]: Leaving directory '/thrift/src/lib'
> make[3]: *** [Makefile:668: distdir] Error 2
> make[3]: Leaving directory '/thrift/src/lib'
> make[2]: *** [Makefile:791: distdir-am] Error 1
> make[2]: Leaving directory '/thrift/src'
> make[1]: *** [Makefile:785: distdir] Error 2
> make[1]: Leaving directory '/thrift/src'
> make: *** [Makefile:894: dist] Error 2
> ```
>
> Better, still not perfect. Not sure where this comes from ... mmmh.
It seems from local testing that the thrift compiler is required to run
`make dist` correctly. Perhaps the original container did not configure all
targets correctly so the dist job for all languages was not actually run?
For example the go library requires `compiler/cpp/thrift` to exist:
```
(cd go && make top_distdir=../../thrift-0.21.0
distdir=../../thrift-0.21.0/test/go \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=:
distdir)
make[5]: Entering directory '/thrift/src/test/go'
Makefile:664: warning: overriding recipe for target 'check'
Makefile:512: warning: ignoring old recipe for target 'check'
grep -v list.*map.*list.*map ../../test/ThriftTest.thrift > ThriftTest.thrift
mkdir -p src/gen
/thrift/src/compiler/cpp/thrift -out src/gen --gen
go:thrift_import=github.com/apache/thrift/lib/go/thrift,package_prefix=github.com/apache/thrift/test/go/src/gen/
ThriftTest.thrift
[WARNING:/thrift/src/test/go/ThriftTest.thrift:43] No generator named
'noexist' could be found!
[WARNING:/thrift/src/test/go/ThriftTest.thrift:45] cpp generator does not
accept 'noexist' as sub-namespace!
/thrift/src/compiler/cpp/thrift -out src/gen --gen
go:thrift_import=github.com/apache/thrift/lib/go/thrift,package_prefix=github.com/apache/thrift/test/go/src/gen/
../StressTest.thrift
[WARNING:/thrift/src/test/StressTest.thrift:31] Consider using the more
efficient "binary" type instead of "list<byte>".
[WARNING:/thrift/src/test/StressTest.thrift:31] Consider using the more
efficient "binary" type instead of "list<byte>".
/thrift/src/compiler/cpp/thrift -out src/gen --gen
go:thrift_import=github.com/apache/thrift/lib/go/thrift,package_prefix=github.com/apache/thrift/test/go/src/gen/
../ConstantsDemo.thrift
touch gopath
```
So once I ran `pushd compiler/cpp/ && make -j `nproc` && popd && make dist`
it would run until the PHP job which I fixed here:
https://github.com/apache/thrift/pull/2937/commits/3b387ed6c5d7786076ad7ce44e982a20280377f2
I think there are 2 options, 1 is to build the thrift compiler first or 2 is
to remove the dependencies on running the thrift compiler and 3 is to configure
without the projects that depend on it . The latter probably requires a bunch
more commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
