thomasbruggink commented on PR #2937: URL: https://github.com/apache/thrift/pull/2937#issuecomment-2012369203
> Note the lack of the $(BUILT_SOURCES) dependency. > > There's a new option **[no-dist-built-sources](https://www.gnu.org/software/automake/manual/html_node/List-of-Automake-options.html#index-Option_002c-no_002ddist_002dbuilt_002dsources)** that basically reverts the change as an opt-in feature. Thanks for the hint :+1: I have no experience with automake so I've tried to figure out where to apply your solution. Updating `AM_INIT_AUTOMAKE` with the `no-dist-built-sources` has the problem that it wont work on automake under version 1.16.5 which is not installable through a package manager on ubuntu 20.04. However even on 1.16.5 it seems this option just doesnt work? I could find [others](https://github.com/stefantalpalaru/transmission-og/blob/c6fe62195b89ec26e1238f83f55744ebf8d0b045/qt/Makefile.am#L350-L355) that seem to have run into the same problem. So the latest commit manually overrides the `distdir` option but removes the dependecy on `BUILT_SOURCES`. This works on both 20.04 and 22.04 for me. Please let me know if this also succeeds for you :bow: if you happen to know a better solutions then I can redo the last commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
