Jens-G commented on PR #2937:
URL: https://github.com/apache/thrift/pull/2937#issuecomment-2005144715

   > Perhaps the original container did not configure all targets correctly so 
the dist job for all languages never actually ran?
   
   Yes and no. It's obviously [some automake 
change](https://www.mail-archive.com/[email protected]&q=subject:%22bug%2349317%5C%3A+dist%5C%3A+depends+on+%24%5C%28BUILT_SOURCES%5C%29%2C+but+has+no+reason+to%22&o=newest&f=1).
 I compared the generated Makefiles and it became rather obvious, because now
   
   '''
   distdir: $(BUILT_SOURCES)
        $(MAKE) $(AM_MAKEFLAGS) distdir-am
   
   distdir-am: $(DISTFILES)
       ...
   '''
   
   but before simply
   
   '''
   distdir: $(DISTFILES)
   '''
   
   Note the lack of the $(BUILT_SOURCES) dependency.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to