sveneld commented on code in PR #2951:
URL: https://github.com/apache/thrift/pull/2951#discussion_r1536762890
##########
.github/workflows/build.yml:
##########
@@ -120,11 +120,11 @@ jobs:
mkdir -p ./lib/php/test/Resources/packages/phpvo
mkdir -p ./lib/php/test/Resources/packages/phpjs
mkdir -p ./lib/php/test/Resources/packages/phpcm
- compiler/cpp/thrift --gen php -r --out
./lib/php/test/Resources/packages/php lib/php/test/Resources/ThriftTest.thrift
- compiler/cpp/thrift --gen php:validate -r --out
./lib/php/test/Resources/packages/phpv lib/php/test/Resources/ThriftTest.thrift
- compiler/cpp/thrift --gen php:validate,oop -r --out
./lib/php/test/Resources/packages/phpvo lib/php/test/Resources/ThriftTest.thrift
- compiler/cpp/thrift --gen php:json -r --out
./lib/php/test/Resources/packages/phpjs lib/php/test/Resources/ThriftTest.thrift
- compiler/cpp/thrift --gen php:classmap,server,rest -r --out
./lib/php/test/Resources/packages/phpcm lib/php/test/Resources/ThriftTest.thrift
+ compiler/cpp/thrift --gen php:nsglobal="Basic" -r --out
./lib/php/test/Resources/packages/php lib/php/test/Resources/ThriftTest.thrift
+ compiler/cpp/thrift --gen php:validate,nsglobal="Validate" -r --out
./lib/php/test/Resources/packages/phpv lib/php/test/Resources/ThriftTest.thrift
+ compiler/cpp/thrift --gen php:validate,oop,nsglobal="ValidateOop" -r
--out ./lib/php/test/Resources/packages/phpvo
lib/php/test/Resources/ThriftTest.thrift
+ compiler/cpp/thrift --gen php:json,nsglobal="Json" -r --out
./lib/php/test/Resources/packages/phpjs lib/php/test/Resources/ThriftTest.thrift
+ compiler/cpp/thrift --gen
php:classmap,server,rest,nsglobal="Classmap" -r --out
./lib/php/test/Resources/packages/phpcm lib/php/test/Resources/ThriftTest.thrift
Review Comment:
In php class can not be reloaded, so i add global namespace for each test
package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
