sveneld commented on code in PR #2951:
URL: https://github.com/apache/thrift/pull/2951#discussion_r1536763035
##########
lib/php/lib/Protocol/TJSONProtocol.php:
##########
@@ -197,68 +195,6 @@ public function readJSONSyntaxChar($b)
}
}
- private function hexVal($s)
- {
- for ($i = 0; $i < strlen($s); $i++) {
- $ch = substr($s, $i, 1);
-
- if (!($ch >= "a" && $ch <= "f") && !($ch >= "0" && $ch <= "9")) {
- throw new TProtocolException("Expected hex character " . $ch,
TProtocolException::INVALID_DATA);
- }
- }
-
- return hexdec($s);
- }
-
- private function hexChar($val)
- {
- return dechex($val);
- }
-
- private function hasJSONUnescapedUnicode()
- {
- if (PHP_MAJOR_VERSION > 5 || (PHP_MAJOR_VERSION == 5 &&
PHP_MINOR_VERSION >= 4)) {
- return true;
Review Comment:
minimal version of php now is 7 so this code will never be used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
