sveneld commented on code in PR #2951:
URL: https://github.com/apache/thrift/pull/2951#discussion_r1536763203
##########
lib/php/lib/Protocol/TJSONProtocol.php:
##########
@@ -297,21 +233,14 @@ private function writeJSONDouble($num)
$this->trans_->write(self::QUOTE);
}
+ #TODO add compatibility with for NAN and INF
Review Comment:
if we will try to make json_encode on such values we will get a silent
error, whic can be readed only by method json_get_last_error. In future should
be added flag THROW_ERROR_ON_EXCEPTION
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
