MartinHaimberger commented on code in PR #2930:
URL: https://github.com/apache/thrift/pull/2930#discussion_r2391921143
##########
lib/dart/lib/src/transport/t_framed_transport.dart:
##########
@@ -29,60 +29,66 @@ class TFramedTransport extends TBufferedTransport {
int _receivedHeaderBytes = 0;
int _bodySize = 0;
- Uint8List _body;
+ Uint8List? _body;
int _receivedBodyBytes = 0;
- Completer<Uint8List> _frameCompleter;
+ Completer<Uint8List>? _frameCompleter;
TFramedTransport(TTransport transport) : _transport = transport {
- if (transport == null) {
- throw ArgumentError.notNull("transport");
- }
+ reset(isOpen: true);
+ // if (transport == null) {
+ // throw ArgumentError.notNull("transport");
+ // }
}
@override
bool get isOpen => _transport.isOpen;
@override
- Future open() {
- _reset(isOpen: true);
+ Future<void> open() {
+ reset(isOpen: true);
return _transport.open();
}
@override
- Future close() {
- _reset(isOpen: false);
+ Future<void> close() {
+ reset(isOpen: false);
return _transport.close();
}
@override
- int read(Uint8List buffer, int offset, int length) {
+ Future<int> read(Uint8List buffer, int offset, int length) async {
if (hasReadData) {
- int got = super.read(buffer, offset, length);
+ int got = await super.read(buffer, offset, length);
if (got > 0) return got;
}
+ // read another frame of data (taken from the Java implementation)
+ // NOT taken from the dart 1 implementation
+ // NOT SURE IF THIS IS THE RIGHT WAY TO DO IT
+ await _readFrame();
Review Comment:
this would change functionality , wouldn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
