Jens-G commented on code in PR #3258:
URL: https://github.com/apache/thrift/pull/3258#discussion_r2608261880


##########
lib/dart/lib/src/browser/t_web_socket.dart:
##########
@@ -71,19 +73,19 @@ class TWebSocket implements TSocket {
     }
 
     _socket = WebSocket(url.toString());
-    _socket.onError.listen(_onError);
-    _socket.onOpen.listen(_onOpen);
-    _socket.onClose.listen(_onClose);
-    _socket.onMessage.listen(_onMessage);
+    _socket!.onError.listen(_onError);

Review Comment:
   Because it cannot be null we need to **override** the check? Is Dart really 
that stupid? Well, in that case ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to