Jens-G commented on code in PR #3258: URL: https://github.com/apache/thrift/pull/3258#discussion_r2572513171
########## lib/dart/lib/src/browser/t_web_socket.dart: ########## @@ -14,6 +14,8 @@ /// KIND, either express or implied. See the License for the /// specific language governing permissions and limitations /// under the License. +/// +/// @author: Dipl. Ing. (FH) Martin Haimberger <[email protected]> Review Comment: https://www.apache.org/legal/src-headers.html#headers Aside from that, for this particular file alone, `git blame` tells me sth different. ########## lib/dart/lib/src/browser/t_web_socket.dart: ########## @@ -71,19 +73,19 @@ class TWebSocket implements TSocket { } _socket = WebSocket(url.toString()); - _socket.onError.listen(_onError); - _socket.onOpen.listen(_onOpen); - _socket.onClose.listen(_onClose); - _socket.onMessage.listen(_onMessage); + _socket!.onError.listen(_onError); Review Comment: I'm personally not such a big fan of overriding null checks via `!` because there is a reason why these checks exist in the first place. It's nice when code runs during the shiny weather, but it should not produce strange, hard to reproduce and hard to spot errors under heavy conditions. ########## lib/dart/lib/src/protocol/t_binary_protocol.dart: ########## @@ -14,6 +14,8 @@ /// KIND, either express or implied. See the License for the /// specific language governing permissions and limitations /// under the License. +/// +/// @author: Dipl. Ing. (FH) Martin Haimberger <[email protected]> Review Comment: etc. ########## lib/dart/lib/src/console/t_tcp_socket.dart: ########## @@ -14,6 +14,8 @@ /// KIND, either express or implied. See the License for the /// specific language governing permissions and limitations /// under the License. +/// +/// @author: Dipl. Ing. (FH) Martin Haimberger <[email protected]> Review Comment: https://www.apache.org/legal/src-headers.html#headers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
