emmenlau commented on code in PR #3226:
URL: https://github.com/apache/thrift/pull/3226#discussion_r2532989349
##########
appveyor.yml:
##########
@@ -40,7 +40,7 @@ environment:
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
PLATFORM: x64
CONFIGURATION: Release
- BUILD_SHARED_LIBS: OFF
+ BUILD_SHARED_LIBS: ON
Review Comment:
Could this be in a separate PR, to add shared library build? This PR here is
99% only about replacing GlobalOutput, which is useful to me independent of
shared libraries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
