CJCombrink commented on code in PR #3226:
URL: https://github.com/apache/thrift/pull/3226#discussion_r2533011726
##########
appveyor.yml:
##########
@@ -40,7 +40,7 @@ environment:
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
PLATFORM: x64
CONFIGURATION: Release
- BUILD_SHARED_LIBS: OFF
+ BUILD_SHARED_LIBS: ON
Review Comment:
It is actually related: In #3229 I disabled building the shared libraries
due to this PR still outstanding with the mention there that I would put it
back, see
https://github.com/apache/thrift/pull/3229/commits/b1e7cfbedf09d6f79a96f7864446bf8b500ad9dd
Also building a shared library was broken and this is (my) the proposed
solution to said problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
