CJCombrink commented on code in PR #3226:
URL: https://github.com/apache/thrift/pull/3226#discussion_r2533771188
##########
appveyor.yml:
##########
@@ -40,7 +40,7 @@ environment:
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
PLATFORM: x64
CONFIGURATION: Release
- BUILD_SHARED_LIBS: OFF
+ BUILD_SHARED_LIBS: ON
Review Comment:
To follow up on [mail
conversation](https://lists.apache.org/thread/283rtxtrg5s1wqr0mhs9knmy75kd9rnx):
The [`CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS
`](https://github.com/apache/thrift/blob/master/build/cmake/DefinePlatformSpecifc.cmake#L59)
does not export global symbols according to the [cmake
docs](https://cmake.org/cmake/help/latest/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html)
> However, there are some cases when compiling code in a consumer may
require explicit dllimport markup:
>
> - Global data symbols must be explicitly marked with __declspec(dllimport)
in order to link to data in the .dll.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
