fishy commented on code in PR #3276: URL: https://github.com/apache/thrift/pull/3276#discussion_r2640614250
########## contrib/fb303/py/setup.py: ########## @@ -20,10 +20,8 @@ # import sys -try: - from setuptools import setup, Extension -except: - from distutils.core import setup, Extension, Command Review Comment: should we keep this (but remove `Command`, looks like that's unused) as fallback for earlier versions of python? (although I'm not familiar of what scenario will have no `setuptools` but `distutils`) ########## lib/py/setup.py: ########## @@ -20,12 +20,9 @@ # import sys -try: - from setuptools import setup, Extension -except Exception: - from distutils.core import setup, Extension Review Comment: same question here regarding fallback to earlier versions of python -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
