greggdonovan commented on code in PR #3276: URL: https://github.com/apache/thrift/pull/3276#discussion_r2690400455
########## contrib/fb303/py/setup.py: ########## @@ -20,10 +20,8 @@ # import sys -try: - from setuptools import setup, Extension -except: - from distutils.core import setup, Extension, Command Review Comment: Thanks for taking a look, @fishy! Do you know what the Thrift support guidelines are for older python versions? e.g. We have a followup PR to add better type support, `ty` type checking, etc. but that's dependent on more modern python versions. The guidelines in LANGUAGES.md appear pretty outdated (i.e. python 3.6.8 is the latest supported). Would we be open to specifying that [EOL python versions](https://devguide.python.org/versions/) are not supported (currently 3.9 and older are EOL, with 3.10 scheduled to go EOL in October 2026)? That would make it much easier to evolve type support and modernize the codebase. In this case, I think relying on setuptools >= 61.0 and dropping distutils limits us to python 3.7+, which seems very reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
