fishy commented on code in PR #3276:
URL: https://github.com/apache/thrift/pull/3276#discussion_r2691054953
##########
.github/workflows/build.yml:
##########
@@ -552,6 +584,64 @@ jobs:
- name: Run make check for python code
run: make -C test/py check
+ lib-python-macos:
+ needs: compiler-macos
+ runs-on: macos-14
+ strategy:
+ matrix:
+ python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
+ fail-fast: false
+ steps:
+ - uses: actions/checkout@v6
+
+ - name: Install dependencies
+ run: |
+ brew install automake bison flex boost libevent openssl libtool
pkg-config
+
+ - name: Set up Python
+ uses: actions/setup-python@v6
+ with:
+ python-version: ${{ matrix.python-version }}
+
+ - name: Python setup
+ run: |
+ python -m pip install --upgrade pip setuptools wheel flake8 tornado
twisted zope.interface
Review Comment:
similar here on possibility to define the list as a variable
##########
.github/workflows/build.yml:
##########
@@ -552,6 +584,64 @@ jobs:
- name: Run make check for python code
run: make -C test/py check
+ lib-python-macos:
+ needs: compiler-macos
+ runs-on: macos-14
+ strategy:
+ matrix:
+ python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
Review Comment:
if `needs` cannot be a matrix, I wonder whether we can define this as a
"variable" somewhere in this yaml, so when we change the supported python
versions in the future we only need to change one place.
##########
.github/workflows/build.yml:
##########
@@ -552,6 +584,64 @@ jobs:
- name: Run make check for python code
run: make -C test/py check
+ lib-python-macos:
+ needs: compiler-macos
Review Comment:
can this also be a matrix instead? (I'm not familiar with github actions
enough so it's totally fine if this is not supported)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
