ndabas opened a new pull request, #3735:
URL: https://github.com/apache/thrift/pull/3735
<!-- Explain the changes in the pull request below: -->
As the title says. It's mostly straightforward.
One of the slightly hacky bits is the change in `lib/py/setup.py` to not
include `compat/win32/stdint.h` when building in CI. That shim is not needed
anyway for most versions of Visual C++/Build Tools found in the wild today.
However I did not get rid of it altogether because someone, somewhere might
have a version that does need it. The AMD64 build seems to work fine in any
case, but on ARM64 the `arm64_neon.h` file chokes on it. Let me know if there
is a better idea to handle this.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
