Copilot commented on code in PR #3735:
URL: https://github.com/apache/thrift/pull/3735#discussion_r3825719688


##########
.github/workflows/pypi.yml:
##########
@@ -109,6 +109,10 @@ jobs:
             runner: windows-latest
             archs: AMD64
             build: "cp310-win_* cp311-win_* cp312-win_* cp313-win_* 
cp314-win_*"
+          - platform: windows-arm64
+            runner: windows-11-arm
+            archs: ARM64
+            build: "cp310-win_* cp311-win_* cp312-win_* cp313-win_* 
cp314-win_*"

Review Comment:
   The ARM64 job requests `cp310-win_arm64`, but CPython's official Windows 
ARM64 builds start at Python 3.11. cibuildwheel therefore cannot create the 
cp310 target on this runner, and with this explicit `CIBW_BUILD` pattern the 
whole ARM64 matrix job can fail instead of producing wheels. Use a separate 
ARM64 build pattern beginning at `cp311` (while keeping cp310 in the AMD64 
entry).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to