Copilot commented on code in PR #3735:
URL: https://github.com/apache/thrift/pull/3735#discussion_r3827925222
##########
lib/py/setup.py:
##########
@@ -35,7 +35,9 @@
include_dirs = ['src']
if sys.platform == 'win32':
- include_dirs.append('compat/win32')
+ # Windows ARM64 builds require the real stdint.h.
+ if os.environ.get('CIBUILDWHEEL') != '1':
+ include_dirs.append('compat/win32')
Review Comment:
Because `CIBUILDWHEEL` is set for every cibuildwheel target, this also
removes `compat/win32` from the existing Windows AMD64 entry (and from users'
AMD64 cibuildwheel builds), not just ARM64. That defeats the stated fallback
for older MSVC toolchains and can make those builds fail when the compiler has
no usable `stdint.h`. Please make the exclusion depend on the ARM64 target
rather than on `CIBUILDWHEEL` alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
