ndabas commented on code in PR #3735:
URL: https://github.com/apache/thrift/pull/3735#discussion_r3828782218
##########
lib/py/setup.py:
##########
@@ -35,7 +35,9 @@
include_dirs = ['src']
if sys.platform == 'win32':
- include_dirs.append('compat/win32')
+ # Windows ARM64 builds require the real stdint.h.
+ if os.environ.get('CIBUILDWHEEL') != '1':
+ include_dirs.append('compat/win32')
Review Comment:
The Python versions we are building wheels for [need Visual C++ 14 or higher
to build](https://wiki.python.org/moin/WindowsCompilers), which includes a
proper `stdint.h` -- therefore, the shim included from `compat/win32` is never
going to be needed for any (AMD64 or ARM64) builds when compiled from
cibuildwheel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
