[ 
http://jira.xwiki.org/jira/browse/XWIKI-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_22241
 ] 

Vincent Massol commented on XWIKI-2058:
---------------------------------------

I fully agree with you. It's pretty stupid to not throw the exception in 
XWikiDefaultPlugin.init()...

BTW a throw XWikiException should also be introduced in 
XWikiPluginInterface.virtualInit()...

Now the problem with this is that it's going to break lots of plugins, inside 
our code base but also all the plugins contributed on code.xwiki.org

IMO the only solution is to:
1) deprecate XWikiDefaultPlugin
2) Introduce a new XWikiPluginAdapter or AbstractXWikiDefaultPlugin that has 
the throws
3) move the plugins in our code base to use the new class in 2)
4) remove XWikiDefaultPlugin later on... (after several new releases of XWiki)

WDYT?


> XWikiDefaultPlugin.init does not throws Exception
> -------------------------------------------------
>
>                 Key: XWIKI-2058
>                 URL: http://jira.xwiki.org/jira/browse/XWIKI-2058
>             Project: XWiki Platform
>          Issue Type: Improvement
>          Components: APIs
>    Affects Versions: 1.3 M1
>            Reporter: Ruslan Shevchenko
>            Priority: Minor
>         Attachments: xwiki_2058_1.patch
>
>
> Now signature of XWikiDefaultPlugin.init()  does not throws any exception.
> But from point of view  author of plugin, exists cases, when plugin ca't be 
> initalized and must throw exception.
> [and XWikiPluginInterface.init()  have exception]
>  so, I propose change signature of XWikiDefaultPlugin.init()  to throw 
> exception

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.xwiki.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
notifications mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/notifications

Reply via email to