[ 
https://issues.apache.org/jira/browse/YETUS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401202#comment-15401202
 ] 

Kengo Seki commented on YETUS-430:
----------------------------------

I think this is a good change, because it reduces LOC per file and enables us 
to modify them without violating our coding guidelines.

bq. Ideally I would have liked to move the jira related classes to some other 
module, say jira_utils.py

Sounds really good, it may facilitate supporting other issue tracking system. 
But I also understand its difficulty. I think we can tackle it on another JIRA 
and improve it gradually.

If there is no objection, I'm going to commit this.

> Refactor releasedocmaker.py in separate modules
> -----------------------------------------------
>
>                 Key: YETUS-430
>                 URL: https://issues.apache.org/jira/browse/YETUS-430
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Release Doc Maker
>            Reporter: Ajay Yadava
>            Assignee: Ajay Yadava
>         Attachments: YETUS-430.00.patch
>
>
> releasedocmaker.py has reached 993 lines in length. We have set the upper 
> limit on number of lines in a file to 1000 in .pylintrc.  New additions to 
> the core functionality will make it trip that line, so I propose to extract 
> utility functions in a separate module. I hope it will improve readability of 
> the script as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to