[
https://issues.apache.org/jira/browse/YETUS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403487#comment-15403487
]
Andrew Wang commented on YETUS-430:
-----------------------------------
Thanks for the ping. Are we dropping support for earlier versions of python
(i.e. 2.5 and down)? That's why we have the simplejson -> json and set -> sets
import fallbacks.
http://stackoverflow.com/questions/712791/what-are-the-differences-between-json-and-simplejson-python-modules
https://docs.python.org/2/library/sets.html
I'm also not a fan of "_str" names for parameters, since "_" is normally used
to indicate a private variable. Here they are parameters, so very much not
private. This is also a good opportunity to rename them to something more
descriptive.
Otherwise looks like a nice refactor, good stuff.
> Refactor releasedocmaker.py in separate modules
> -----------------------------------------------
>
> Key: YETUS-430
> URL: https://issues.apache.org/jira/browse/YETUS-430
> Project: Yetus
> Issue Type: Improvement
> Components: Release Doc Maker
> Reporter: Ajay Yadava
> Assignee: Ajay Yadava
> Attachments: YETUS-430.00.patch
>
>
> releasedocmaker.py has reached 993 lines in length. We have set the upper
> limit on number of lines in a file to 1000 in .pylintrc. New additions to
> the core functionality will make it trip that line, so I propose to extract
> utility functions in a separate module. I hope it will improve readability of
> the script as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
