[
https://issues.apache.org/jira/browse/YETUS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403548#comment-15403548
]
Ajay Yadava commented on YETUS-430:
-----------------------------------
Thank you [~andrew.wang] and [~sekikn] for the review.
{quote}
I'm also not a fan of "_str" names for parameters, since "_" is normally used
to indicate a private variable. Here they are parameters, so very much not
private. This is also a good opportunity to rename them to something more
descriptive.
{quote}
I also agree and will be happy to fix it :)
Since this JIRA has the attention of all the pythonistas and we are discussing
versions, may I broach a slight aside(more suitable for another JIRA probably)?
Will it be useful to drop support for 2.6 and provide support for 3.x along
with 2.7? I believe that will help in reaching out to a wider audience.
h5. Why not support >=2.6 and 3.x?
One of the reasons is that the optparse module is deprecated since 2.7 version
of python and is not available in python3. There might be more as I haven't
done full analysis yet.
If this looks like a step in correct direction then I can probably start a
DISCUSS thread or create a new JIRA for more detailed discussion.
> Refactor releasedocmaker.py in separate modules
> -----------------------------------------------
>
> Key: YETUS-430
> URL: https://issues.apache.org/jira/browse/YETUS-430
> Project: Yetus
> Issue Type: Improvement
> Components: Release Doc Maker
> Reporter: Ajay Yadava
> Assignee: Ajay Yadava
> Attachments: YETUS-430.00.patch
>
>
> releasedocmaker.py has reached 993 lines in length. We have set the upper
> limit on number of lines in a file to 1000 in .pylintrc. New additions to
> the core functionality will make it trip that line, so I propose to extract
> utility functions in a separate module. I hope it will improve readability of
> the script as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
