[ 
https://issues.apache.org/jira/browse/YETUS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15472566#comment-15472566
 ] 

Andrew Wang commented on YETUS-457:
-----------------------------------

Thanks for doing all the testing, I wasn't calling pandoc with markdown_mmd. 
I'll rev after this next round of q's.

bq. Take a look at HDFS-9220 in...<angle brackets>

This one works because there's just a single left-angle-bracket, and thus 
doesn't look like an HTML tag. But, from Daring Fireball:

{quote}
Similarly, because Markdown supports inline HTML, if you use angle brackets as 
delimiters for HTML tags, Markdown will treat them as such.
{quote}

I tested my example "Add missing <i> tag" outside RDM with pandoc and it passes 
the <i> through unescaped.

To sum it up, I think my proposal is:

* HTML encode single quote and angle brackets (or, at least left angle brackets)
* Update comments/docs to make it clear we're outputting markdown_mmd rather 
than "standard" markdown
* Maybe: slash escape square brackets and $?

Regarding the JIRA IDs, sure we can not escape hyphen, but would you mind if I 
still changed write_list to not pass them through sanitize_text? It still seems 
wrong semantically if we don't actually want to escape anything.

> RDM does not properly escape entities
> -------------------------------------
>
>                 Key: YETUS-457
>                 URL: https://issues.apache.org/jira/browse/YETUS-457
>             Project: Yetus
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>            Priority: Critical
>         Attachments: YETUS-457.001.patch, YETUS-457.002.patch
>
>
> Noticed while browsing the Hadoop 3.0.0-alpha1 changelog. Quotes and possibly 
> some other entities are not escaped properly, leading to malformed markdown 
> output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to