[
https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732656#comment-15732656
]
Sean Busbey commented on YETUS-471:
-----------------------------------
{quote}
This issue occurs because findbugs plugin runs only on src/main/java directory
by default and there is no src/main/java directory in hadoop-yarn-server-tests
module (i.e. the module has test code only). That way the plugin does not
output findbugsXml.xml and findbugs_runner set -1 to the module. To fix this
issue, I'd like to make the findbugs source folders to src/main/java only by
default. Of course I'm okay with changing the default source folders in a
separate jira.
{quote}
thanks [~ajisakaa], that sounds like an error (that we currently presume either
main or test sources will be used rather than just main sources). We should fix
that in a different JIRA regardless of the approach taken in this jira.
{quote}
This isn't about optimization; this is about skipping false positives. Bad
Things(tm) happen when run in a module that doesn't have source.
{quote}
Even as a way of avoiding false positives it seems like our best bet to avoid
tooling around non-standard maven deploys is to have an escape hatch that
essentially says "stop assuming the maven project structure is the maven
standard". We could ask maven to list the configured source directories, but do
we want to head down that route?
> Add possibility to configure Findbugs source folders
> ----------------------------------------------------
>
> Key: YETUS-471
> URL: https://issues.apache.org/jira/browse/YETUS-471
> Project: Yetus
> Issue Type: Improvement
> Components: Test Patch
> Affects Versions: 0.3.0
> Reporter: Peter Vary
> Assignee: Peter Vary
> Attachments: YETUS-471.00.patch, YETUS-471.01.patch,
> YETUS-471.02.patch
>
>
> Trying to add yetus as a pre-commit test for Hive (see HIVE-15051)
> Findbugs plugin currently expects the project structure to be the standard
> maven one (/src/main/java, /src/test/java). In Hive some of the modules have
> a different file layout. It would be good to have a parameter introduced to
> enable changes in checking directories.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
