TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314580611
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
##########
@@ -1268,11 +1256,7 @@ public void run() {
} else if (e instanceof SocketException) {
LOG.info("Socket error occurred: {}: {}",
serverAddress, e.getMessage());
} else {
- LOG.warn("Session 0x{} for server {}, unexpected
error{}",
- Long.toHexString(getSessionId()),
- serverAddress,
- RETRY_CONN_MSG,
- e);
+ LOG.warn("Session 0x{} for server {}, unexpected
error{}", Long.toHexString(getSessionId()), serverAddress, RETRY_CONN_MSG, e);
Review comment:
It is possible that we enable `LineBreak` rule on zookeeper-server that
forbid every line exceed a preconfigure value. See ZOOKEEPER-3508 for it.
We can tell an auto-formatter to break a line but it would introduce awful
breaks as Enrico request to change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
