hanm commented on a change in pull request #1235: ZOOKEEPER-3706:
ZooKeeper.close() would leak SendThread when the netw…
URL: https://github.com/apache/zookeeper/pull/1235#discussion_r374381726
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
##########
@@ -782,6 +782,10 @@ void queueCallback(AsyncCallback cb, int rc, String path,
Object ctx) {
eventThread.queueCallback(cb, rc, path, ctx);
}
+ protected void onConnecting(InetSocketAddress addr) {
+ LOG.info("Try to connect to server {}.", addr);
Review comment:
Since the primary reason of adding this is for injection in unit tests, I'd
suggest we mark this method which a comment like "for tests only", and remove
the log statement which if leaving as is, will create a lot of noises in client
side logs. We can still override an empty method in test implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
